Error handling and logging improvements via re-raising #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grzuy
commented
Sep 18, 2024
| defp handle_error(kind, reason, stacktrace, transport, span, opts) do | ||
| # TODO: Fix this telementry kind | ||
| Bandit.Telemetry.span_exception(span, :exit, reason, stacktrace) | ||
| status = reason |> Plug.Exception.status() |> Plug.Conn.Status.code() | ||
|
|
||
| if status in Keyword.get(opts.http, :log_exceptions_with_status_codes, 500..599) do |
There was a problem hiding this comment.
Ideally this conditional would be inside the Bandit.LoggerTranslator. Need a way to access the opts.http from there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential alternative to #398 .
Proof of concept still.
Haven't yet tested how compatible is with earlier elixir/otp versions.
This moves to do something "similar" to what plug_cowboy does in https://github.com/elixir-plug/plug_cowboy/blob/ced253f035f2a07ebed17cfacb64d4f16357a750/lib/plug/cowboy/handler.ex#L21-L23.